Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ETHER: Make sure SET NOASYNC is effective for Ethernet devices #340

Merged
merged 1 commit into from
Feb 1, 2024
Merged

ETHER: Make sure SET NOASYNC is effective for Ethernet devices #340

merged 1 commit into from
Feb 1, 2024

Conversation

markpizz
Copy link
Contributor

@markpizz markpizz commented Jan 5, 2024

SET NOASYNC is intended to disable asynchronous threads from interacting with the simulator event system.

The only cases where there asynchronous threads are:

  1. Disks which are designed for asynchronous support using sim_disk. The only case is the MSCP controller implemented by pdp11_rq (Device name RQ).
  2. Tapes which are designed for asynchronous support using sim_tape. The only case is the TMSCP controller implemented by pdp11_tq (Device name TQ).
  3. Devices which use sim_ether to interface with Ethernet networks. There are a number of these cases.

Prior to this change, SET NOASYNC only actually affected the RQ and TQ devices and had no effect on Ethernet devices.

hharte
hharte approved these changes Jan 6, 2024
View reviewed changes
Copy link
Contributor

@hharte hharte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mark,

The change looks good, and it makes sense for the Ethernet to behave similarly to the other async (TQ and RQ) devices.

@markpizz
ETHER: Make sure SET NOASYNC is effective for Ethernet devices
494ef0b 
- Make sure that asynchronous mode can't be changed if devices using
   sim_ether are already attached.
- Add missing DEV_ETHER type flag for the only sim_ether using device
   that didn't already have it.
@markpizz
Copy link
Contributor Author

markpizz commented Jan 7, 2024

Minimal change to only sim_ether would be effective if it occurred before sim_ether using device code was not yet attached. This most recent change added an Ethernet device check for the device attached state before changing the asynchronous mode.

@pkoning2 pkoning2 merged commit 7a6a325 into open-simh:master Feb 1, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hharte hharte hharte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markpizz @hharte @pkoning2